Skip to content

feat: expose prosemirrorState again? #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

feat: expose prosemirrorState again? #1615

merged 2 commits into from
Apr 23, 2025

Conversation

nperez0111
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Apr 18, 2025 7:39am
blocknote-website ✅ Ready (Inspect) Visit Preview Apr 18, 2025 7:39am

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 17, 2025 •
edited
Loading

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@1615

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@1615

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@1615

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@1615

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@1615

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@1615

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@1615

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@1615

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@1615

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@1615

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@1615

commit: 614ef28

YousefED
YousefED reviewed Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; anything specifically that triggered you to re-add this?

@nperez0111
Copy link
Contributor Author

It was triggered by this:

BlockNote/packages/core/src/api/positionMapping.ts

Line 98 in 5edf299

editor._tiptapEditor.state

To get a plugin state, you need the editor state. So, at some level it needs to be exposed. I figured it better to expose as a top-level with an error on incorrect usage than not having it at all

@nperez0111 nperez0111 merged commit 5aed7e9 into main Apr 23, 2025
8 checks passed
@nperez0111 nperez0111 deleted the prosemirrorState branch April 23, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YousefED YousefED YousefED approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nperez0111 @YousefED